Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep directory and use to infer write location #210

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Keep directory and use to infer write location #210

merged 2 commits into from
Feb 9, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

When loading partition info from a directory (which is what we do when we load from Catalog API), keep the catalog base directory for later use when writing out the files. We can infer the desired location, and construct paths on behalf of the user.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

Before [c2e8bfd] After [c2df54e] Ratio Benchmark (Parameter)
123±0.4ms 125±0.9ms 1.02 benchmarks.time_test_alignment_even_sky
98.9±1ms 98.6±0.7ms 1 benchmarks.time_test_cone_filter_multiple_order
82.0±1ms 81.1±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
652±5ms 642±8ms 0.99 benchmarks.Suite.time_pixel_tree_creation
82.1±0.6ms 80.6±0.3ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order7
20.4±0.4ms 19.7±0.2ms 0.97 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

camposandro
camposandro approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I detected a missing argument in the docstrings, other than that it looks good!

src/hipscat/catalog/association_catalog/partition_join_info.py Show resolved Hide resolved
src/hipscat/catalog/partition_info.py Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 684cd83 into main Feb 9, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/partition_info branch February 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camposandro camposandro camposandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @camposandro